Skip to content

Replace speex with opus #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Replace speex with opus #895

wants to merge 13 commits into from

Conversation

jushar
Copy link
Contributor

@jushar jushar commented Apr 27, 2019 •
edited by StrixG
Loading

Speex was deprecated years ago because opus is in all respects better.

Since this change introduces breaking changes (voice packets are totally different), we have to merge this in a major version.

  • Replace portaudio in favour of using BASS for recording
  • Use opus

If anyone has interest in finishing this, feel free to do so!

@jushar jushar added the enhancement New feature or request label Apr 27, 2019
@jushar jushar added this to the 1.6 milestone Apr 27, 2019
@jushar jushar added the help wanted Extra attention is needed label Apr 27, 2019
@patrikjuvonen
Copy link
Contributor

I started working on finishing this a while back at https://github.com/patrikjuvonen/mtasa-blue/tree/libopus but had some memory related crashes at the time, I'll try to look at this one again.

@patrikjuvonen patrikjuvonen self-assigned this Apr 27, 2019
@patrikjuvonen patrikjuvonen changed the title Replace speex with opus WIP: Replace speex with opus May 12, 2019
@prnxdev
Copy link

prnxdev commented May 16, 2019

Can't wait to see this working

@Dutchman101 Dutchman101 mentioned this pull request May 26, 2019
Closed
@qaisjp qaisjp changed the title WIP: Replace speex with opus Replace speex with opus May 27, 2019
@Dutchman101
Copy link
Member

Since this change introduces breaking changes (voice packets are totally different), we have to merge this in a major version.

Do you think we can get this ready for 1.6?

@Dutchman101 Dutchman101 mentioned this pull request Dec 12, 2019
Open
3 tasks
@qaisjp qaisjp mentioned this pull request Apr 9, 2020
Merged
1 task
@qaisjp qaisjp modified the milestones: 1.5.8, 1.6 Apr 20, 2020
@patrikjuvonen patrikjuvonen added the upstream Related to vendor library label Aug 8, 2020
@botder botder removed this from the 1.6 milestone Feb 3, 2021
@botder botder added this to the Spring Maintenance milestone Feb 3, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Jan 7, 2022
@patrikjuvonen patrikjuvonen added keep This pull request is exempt from stale checks and removed stale Inactive for over 90 days, to be closed labels Jan 7, 2022
@patrikjuvonen patrikjuvonen removed their assignment Jun 12, 2023
@patrikjuvonen patrikjuvonen removed this from the Next Release (1.6.1) milestone Jun 12, 2023
@Wannacry-ops
Copy link

Opus Opus

@Fernando-A-Rocha
Copy link
Contributor

🧐

@botder
Copy link
Member

botder commented Dec 31, 2024

I am going to close this pull request because it's not being maintained and probably requires a fresh start anyway. Anyone can feel free to pick up the effort and create a new pull request.

@botder botder closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed keep This pull request is exempt from stale checks upstream Related to vendor library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jushar @patrikjuvonen @prnxdev @Dutchman101 @Wannacry-ops @Fernando-A-Rocha @botder @qaisjp @sbx320